Skip to content

bpo-39002: Fix simple typo: tranlation -> translation (GH-17517)#17517

Merged
rhettinger merged 2 commits into
python:masterfrom
timgates42:bugfix/typo_translation
Dec 9, 2019
Merged

bpo-39002: Fix simple typo: tranlation -> translation (GH-17517)#17517
rhettinger merged 2 commits into
python:masterfrom
timgates42:bugfix/typo_translation

Conversation

@timgates42

@timgates42 timgates42 commented Dec 9, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

There is a small typo in Lib/test/test_statistics.py.
Should read translation rather than tranlation.

https://bugs.python.org/issue39002

@the-knights-who-say-ni

the-knights-who-say-ni commented Dec 9, 2019

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@timgates42

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Dec 9, 2019
@timgates42
bpo-39002: Fix simple typo. (GH-17517)
dad7af3 
There is a small typo in Lib/test/test_statistics.py.
Should read `translation` rather than `tranlation`.
@timgates42 timgates42 changed the title Fix simple typo: tranlation -> translation bpo-39002: Fix simple typo: tranlation -> translation (GH-17517) Dec 9, 2019
corona10
corona10 approved these changes Dec 9, 2019
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timgates42

Thanks for the contribution to cpython project.
Please sign up the CLA please, after that core developers will review your PR :)
Thank you again!

@corona10 corona10 requested a review from rhettinger December 9, 2019 12:17
@rhettinger rhettinger merged commit c18b805 into python:master Dec 9, 2019
@miss-islington

miss-islington commented Dec 9, 2019

Copy link
Copy Markdown
Contributor

Thanks @timgates42 for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 9, 2019
@timgates42 @miss-islington
bpo-39002: Fix simple typo: tranlation -> translation (pythonGH-17517)
d930070 
(cherry picked from commit c18b805)

Co-authored-by: Tim Gates <tim.gates@iress.com>
@bedevere-bot

bedevere-bot commented Dec 9, 2019

Copy link
Copy Markdown

GH-17538 is a backport of this pull request to the 3.8 branch.

@timgates42

timgates42 commented Dec 9, 2019

Copy link
Copy Markdown
Contributor Author

Thanks @corona10 - not to worry I did sign it yesterday and the check-python-cla site is now reporting that I'm all signed up - Thanks all!

rhettinger pushed a commit that referenced this pull request Dec 10, 2019
@miss-islington @timgates42 @rhettinger
bpo-39002: Fix simple typo: tranlation -> translation (GH-17517) (GH-…
859767d 
…17538)

(cherry picked from commit c18b805)

Co-authored-by: Tim Gates <tim.gates@iress.com>
merwok
merwok reviewed Dec 19, 2019
View reviewed changes
Comment thread Misc/ACKS
Tim Hopper
Dan Lidral-Porter
Ngalim Siregar
Tim Gates

@merwok merwok Dec 19, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future PRs, please keep the ordering (alphabetical by last name) in this file. Thanks!

@timgates42 timgates42 Dec 20, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry - I didn't realize.

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@timgates42 @shihai1991
bpo-39002: Fix simple typo: tranlation -> translation (pythonGH-17517)
9553427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments
@rhettinger rhettinger rhettinger approved these changes
@corona10 corona10 corona10 approved these changes

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@timgates42 @the-knights-who-say-ni @miss-islington @bedevere-bot @merwok @rhettinger @corona10